chore_: remove private information for error log #6334
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (16)
|
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (21.47%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6334 +/- ##
===========================================
- Coverage 60.42% 60.38% -0.05%
===========================================
Files 845 845
Lines 111357 111371 +14
===========================================
- Hits 67289 67251 -38
- Misses 36270 36301 +31
- Partials 7798 7819 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
qfrank
force-pushed
the
chore/remove_private_info_for_error_log
branch
from
e83da29 to
f5be723
Compare
This commit adds a utility function from the common package to truncate sensitive information (like addresses, IDs, etc.) in error messages across multiple files. This helps prevent accidentally exposing full sensitive data in logs and error messages while maintaining readability.
qfrank
force-pushed
the
chore/remove_private_info_for_error_log
branch
from
f5be723 to
24cd545
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate comment
I've also tried search with keyword:
fmt.Error:fmt.Errorf-search-result.txt.zip
truncated some sensitive information in error messages.