Chat animation #140
Merged
Chat animation #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The next step is to add some sugar for views with animation |
Closed
|
curious what orientation is used for (i mean we need it eventually) |
|
It is used for calculation related to suggestion's header "sticking" https://github.com/status-im/status-react/blob/chat-animation/src/status_im/chat/views/response.cljs#L46 |
|
ehh, i have to add comments there |
|
want to fix* conflicts now and add comments and i'll merge |
|
ok |
Conflicts: .re-natal src/status_im/android/core.cljs src/status_im/chat/views/message_input.cljs src/status_im/chat/views/plain_message.cljs src/status_im/db.cljs
0xc1c4da
added a commit
that referenced
this pull request
Jan 5, 2017
Chat animation Former-commit-id: 31d7161
This was referenced Jan 18, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This was referenced Oct 9, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to simplify the logic of triggering of the chat's animation. Now all animations related to changes of
edit-modeare triggered by(dispatch [:command-edit-mode])/(dispatch [:text-edit-mode]).