Pass WhisperConfig.LightClient: true in node config. Closes #3442
#3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedropombeiro
force-pushed
the
feature/shh.lightclient-#3442
branch
2 times, most recently
from
a53fc6a to
90e40dd
Compare
janherich
approved these changes
Feb 27, 2018
Automated test results:test_contact_profile_view:white_check_mark::Test Steps & Error message:test_network_switch:white_check_mark::Test Steps & Error message:test_browse_link_entering_url_in_dapp_view:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_now:white_check_mark::Test Steps & Error message:test_transaction_send_command_wrong_password:white_check_mark::Test Steps & Error message:test_send_stt_from_wallet_via_enter_recipient_address:white_check_mark::Test Steps & Error message:test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:test_transaction_send_command_group_chat:white_check_mark::Test Steps & Error message:test_public_chat:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_later:white_check_mark::Test Steps & Error message:test_group_chat_messages:white_check_mark::Test Steps & Error message:test_one_to_one_chat_messages_and_delete_chat:white_check_mark::Test Steps & Error message:test_transaction_send_command_one_to_one_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_one_to_one_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_group_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_from_wallet:white_check_mark::Test Steps & Error message: |
|
I have checked basic messaging functionality - 1x1 , group and public chats in this PR currently and when upgrading release version to this PR. Messaging works the same way, I can send / receive messages. I don't see the WhisperConfig.LightClient JSON on android geth log but i assume it depends on log level. Traffic consumption will have an effect with Whisper v6, which we will have later. |
|
I'm finally able again to deploy to my Android phone and was able to see that while |
pedropombeiro
force-pushed
the
feature/shh.lightclient-#3442
branch
from
90e40dd to
648baeb
Compare
|
Fixed the issue. The log now shows: {
"DevMode": true,
"NetworkId": 3,
"DataDir": "\/data\/user\/0\/im.status.ethereum\/ethereum\/testnet_rpc",
"KeyStoreDir": "\/data\/user\/0\/im.status.ethereum\/keystore",
"NodeKeyFile": "",
"Discovery": false,
"ListenAddr": ":0",
"Name": "StatusIM",
"Version": "0.9.9-unstable",
"APIModules": "db,eth,net,web3,shh,personal,admin,debug",
"HTTPHost": "localhost",
"RPCEnabled": false,
"HTTPPort": 8545,
"WSHost": "localhost",
"WSPort": 8546,
"WSEnabled": false,
"IPCFile": "geth.ipc",
"IPCEnabled": false,
"TLSEnabled": false,
"MaxPeers": 25,
"MaxPendingPeers": 0,
"LogFile": "\/storage\/emulated\/0\/Download\/geth.log",
"LogLevel": "INFO",
"LogToStderr": true,
"UpstreamConfig": {
"Enabled": true,
"URL": "https:\/\/ropsten.infura.io\/z6GCTmjdP3FETEJmMBI4"
},
"BootClusterConfig": {
"Enabled": true,
"BootNodes": ["enode:\/\/1b995ba494e880e9b55fa0c093eb94db2d9de65de473d0fbd173f1d5af86f1c99da57e68fb00e58303c2b7abbbcd59396c7293c6c865ead4e5334feab4397feb@163.172.168.202:30303", "enode:\/\/1b995ba494e880e9b55fa0c093eb94db2d9de65de473d0fbd173f1d5af86f1c99da57e68fb00e58303c2b7abbbcd59396c7293c6c865ead4e5334feab4397feb@51.15.194.39:30303"]
},
"LightEthConfig": {
"Enabled": true,
"Genesis": "...",
"DatabaseCache": 16
},
"WhisperConfig": {
"Enabled": true,
"PasswordFile": "",
"Password": "",
"LightClient": true,
"EnableMailServer": false,
"DataDir": "\/data\/user\/0\/im.status.ethereum\/ethereum\/testnet\/wnode",
"MinimumPoW": 0.001,
"TTL": 120,
"FirebaseConfig": {
"AuthorizationKeyFile": "",
"NotificationTriggerURL": "https:\/\/fcm.googleapis.com\/fcm\/send"
}
},
"SwarmConfig": {
"Enabled": false
},
"LogEnabled": true
} |
|
@pombeirp Shall we retest this PR? |
|
@jeluard let me just push and I think we can merge directly. |
pedropombeiro
force-pushed
the
feature/shh.lightclient-#3442
branch
from
648baeb to
13f3dcf
Compare
|
Ready to be merged |
- Add code to completely dump the JSON config, not just the first 4000 characters. Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
jeluard
force-pushed
the
feature/shh.lightclient-#3442
branch
from
13f3dcf to
bb2a008
Compare
This was referenced Oct 5, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the new functionality in status-go
feature/whisperv6-#665to use bloom filters to filter out unwanted topics on light nodes.fixes #3442
Testing notes (optional):
I haven't been able to deploy to the phone for testing (looks like
developis not stable).status: ready