Skip to content

feat: add base/truncate-middle string package #1118

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Conversation

steff456
Copy link
Contributor

Part of #1062

Description

What is the purpose of this pull request?

This pull request:

  • Adds @stdlib/string/base/truncate-middle

Related Issues

Does this pull request have any related issues?

This pull request:

Part of #1062

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@steff456 steff456 requested a review from kgryte October 30, 2023 17:40
@steff456 steff456 self-assigned this Oct 30, 2023
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
string/base/truncate-middle $\color{green}130/130$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}130/130$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
string/base/truncate-middle $\color{green}130/130$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}130/130$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Oct 31, 2023
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
string/base/truncate-middle $\color{green}129/129$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}129/129$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steff456 Thanks for working on this. A few minor cleanup concerns and a request to update descriptions. Once resolved, this should be ready for merge.

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
string/base/truncate-middle $\color{green}129/129$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}129/129$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
string/base/truncate-middle $\color{green}131/131$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}131/131$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
string/base/truncate-middle $\color{green}132/132$
$\color{green}+100.00\%$
$\color{red}8/9$
$\color{green}+88.89\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}132/132$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte merged commit d859ee0 into develop Nov 10, 2023
@kgryte kgryte deleted the base-truncate-middle branch November 10, 2023 21:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants