Skip to content

bench: update assert/is-boolean benchmarks to measure affirmative/negative test values #1458

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

Snehil-Shah
Copy link
Member

@Snehil-Shah Snehil-Shah commented Mar 2, 2024

Partially Resolves #1148

Description

What is the purpose of this pull request?

This pull request:

  • updates @stdlib/assert/is-boolean benchmarks to measure affirmative/negative test values for all cases

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

…tive/negative test values

Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com>
@Planeshifter Planeshifter changed the title bench: update @stdlib/assert/is-boolean benchmarks to measure affirmative/negative test values bench: update assert/is-boolean benchmarks to measure affirmative/negative test values Mar 3, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@Planeshifter Planeshifter merged commit a8676e3 into stdlib-js:develop Mar 3, 2024
bad-in-coding pushed a commit to bad-in-coding/stdlib that referenced this pull request Mar 7, 2024
…egative test values

PR-URL: stdlib-js#1458

Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Snehil-Shah Snehil-Shah deleted the is-boolean-benchmarks branch April 26, 2024 12:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Update @stdlib/assert/* benchmarks to measure affirmative/negative test values
2 participants