Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat!: add C implementation for math/base/special/ceilsd #2631

Merged
merged 2 commits into from
Jul 20, 2024
Merged

feat!: add C implementation for math/base/special/ceilsd #2631

merged 2 commits into from
Jul 20, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jul 20, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_ceilsd( const double x, const int32_t n, const int32_t b );
  • refactors javascript implementation to make the third argument, b, as mandatory.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

I have added a ! in the commit message to indicate that this PR has breaking changes.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jul 20, 2024
@Planeshifter Planeshifter self-requested a review July 20, 2024 16:04
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Jul 20, 2024
@Planeshifter
docs: fix return annotation value
c2d60e4 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Planeshifter Planeshifter merged commit 854b793 into stdlib-js:develop Jul 20, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the ceilsd branch July 21, 2024 03:21
kgryte pushed a commit that referenced this pull request Jul 21, 2024
@gunjjoshi
test: fix tests for native implementation
6a0cbd9 
PR-URL: #2641
Ref: #2631
Ref: 854b793
Reviewed-by: Athan Reines <kgryte@gmail.com>
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
@gunjjoshi @Planeshifter
feat!: add C implementation for math/base/special/ceilsd
be60073 
PR-URL: stdlib-js#2631
Ref: stdlib-js#649 

---------

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
@gunjjoshi
test: fix tests for native implementation
28d7e8e 
PR-URL: stdlib-js#2641
Ref: stdlib-js#2631
Ref: stdlib-js@854b793
Reviewed-by: Athan Reines <kgryte@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunjjoshi @Planeshifter @stdlib-bot