Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: handle edge cases in the tokenizer for syntax highlighting in the REPL #2770

Merged
merged 1 commit into from
Aug 10, 2024
Merged

fix: handle edge cases in the tokenizer for syntax highlighting in the REPL #2770

merged 1 commit into from
Aug 10, 2024

Conversation

Snehil-Shah
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • fixes a weird edge case that I encountered where acorn was producing tokens with the start index greater than the end index, causing unwanted behavior.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Snehil-Shah
fix: handle tokens where start idx is greater than end idx
a1fe71d 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@Snehil-Shah Snehil-Shah added the REPL Issue or pull request specific to the project REPL. label Aug 10, 2024
Planeshifter
Planeshifter approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Aug 10, 2024
@Planeshifter Planeshifter merged commit ea8303e into stdlib-js:develop Aug 10, 2024
19 checks passed
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
@Snehil-Shah @gunjjoshi
fix: handle tokens where start idx is greater than end idx
298749e 
PR-URL: stdlib-js#2770

Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged. REPL Issue or pull request specific to the project REPL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Snehil-Shah @Planeshifter