Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: add math/base/special/acotdf #2799

Merged
merged 2 commits into from
Aug 23, 2024
Merged

feat: add math/base/special/acotdf #2799

merged 2 commits into from
Aug 23, 2024

Conversation

gunjjoshi
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

float stdlib_base_acotdf( const float x );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Aug 16, 2024
Planeshifter
Planeshifter approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Aug 18, 2024
kgryte
kgryte requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Once the benchmarks are updated, I'll approve and merge.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Ready To Merge A pull request which is ready to be merged. labels Aug 23, 2024
kgryte
kgryte approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte merged commit 50b38f9 into stdlib-js:develop Aug 23, 2024
10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gunjjoshi @Planeshifter @kgryte @stdlib-bot