Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add C implementation for arcsine CDF #3354

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Conversation

Planeshifter
Copy link
Member

@Planeshifter Planeshifter commented Dec 7, 2024

Resolves #3384 .

Description

What is the purpose of this pull request?

This pull request:

  • Adds a C implementation of the arcsine cumulative distribution function (CDF).
  • Includes benchmarks for the C implementation.
  • Provides examples demonstrating the usage of the arcsine CDF in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 7, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/arcsine/cdf $\color{green}317/317$
$\color{green}+100.00\%$
$\color{green}27/27$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}317/317$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
@Planeshifter Planeshifter marked this pull request as ready for review December 7, 2024 14:03
@Planeshifter Planeshifter requested a review from kgryte December 7, 2024 14:03
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 7, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality. labels Dec 11, 2024
@kgryte
Copy link
Member

kgryte commented Dec 11, 2024

This PR is also missing benchmark.native.js.

Planeshifter and others added 2 commits December 10, 2024 21:02
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
This was referenced Dec 13, 2024

// MAIN //

bench( pkg, opts, function benchmark( b ) {
Copy link
Member

@kgryte kgryte Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing pkg+'::native'.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/arcsine/cdf
3 participants