Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add C implementation for stats/base/dists/t/kurtosis #3905

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

aayush0325
Copy link
Member

Resolves #3871

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/t/kurtosis along with relevant docs, tests, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 14, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 14, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/t/kurtosis $\color{green}181/181$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}181/181$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@aayush0325
Copy link
Member Author

good afternoon, i've pushed the requested changes @kgryte!

@aayush0325 aayush0325 requested a review from kgryte December 16, 2024 09:19
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment regarding range of benchmark values, but otherwise LGTM!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 16, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 16, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/t/kurtosis`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3905
Closes: https://github.com/stdlib-js/stdlib/issues/3871

Co-authored-by: aayush0325 <ayush25khanna@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@aayush0325
Copy link
Member Author

good evening @Planeshifter! i've pushed the requested changes.

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 16, 2024
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Dec 16, 2024
@Planeshifter Planeshifter merged commit 6a2b590 into stdlib-js:develop Dec 16, 2024
21 checks passed
sethdivyansh pushed a commit to sethdivyansh/stdlib that referenced this pull request Dec 16, 2024
PR-URL: stdlib-js#3905
Closes: stdlib-js#3871

Co-authored-by: aayush0325 <ayush25khanna@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/t/kurtosis
4 participants