-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: wrap void function call in API_SUFFIX
#4603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
these are the only packages where the change was applicable, i'll keep this in mind moving forward |
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0PrashantYadav0
pushed a commit
to 0PrashantYadav0/stdlib
that referenced
this pull request
Jan 9, 2025
PR-URL: stdlib-js#4603 Reviewed-by: Athan Reines <kgryte@gmail.com>
Neerajpathak07
pushed a commit
to Neerajpathak07/stdlib
that referenced
this pull request
Jan 23, 2025
PR-URL: stdlib-js#4603 Reviewed-by: Athan Reines <kgryte@gmail.com>
ShabiShett07
pushed a commit
to ShabiShett07/stdlib
that referenced
this pull request
Feb 26, 2025
PR-URL: stdlib-js#4603 Reviewed-by: Athan Reines <kgryte@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
API_SUFFIX
in packages related to cumulative maximum/minimumRelated Issues
No.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers