Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expand file_pattern-input to an array #205

Merged
merged 12 commits into from
Sep 17, 2022

Conversation

stefanzweifel
Copy link
Owner

@stefanzweifel stefanzweifel commented Feb 27, 2022

entrypoint.sh Outdated Show resolved Hide resolved
entrypoint.sh Outdated Show resolved Hide resolved
entrypoint.sh Outdated Show resolved Hide resolved
@stefanzweifel stefanzweifel marked this pull request as ready for review September 14, 2022 18:04
@stefanzweifel
Copy link
Owner Author

I've tested this change in my test repository here: stefanzweifel/git-auto-commit-action-demo-app#35

The file_pattern works much better now, but there is still an issue with globbing: If an untouched file that matches the pathspec is in the repository, the Action still fails with a Working tree clean. Nothing to commit.-mesage.
However, this can be resolved by adding disable_globbing: true to a workflow.
(Globbing is not disabled by default, due to the fear of breaking the workflow of others. See #154 for details.)

I'm gonna merge this PR to master now. A new version will be tagged after 5-6 days, if no bug reports are coming in.

@stefanzweifel stefanzweifel merged commit 4d00f10 into master Sep 17, 2022
@stefanzweifel stefanzweifel deleted the refactor/expand-file-pattern branch September 17, 2022 13:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants