Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

stellar smart contract #24

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

stellar smart contract #24

wants to merge 8 commits into from

Conversation

Ugo-X
Copy link

@Ugo-X Ugo-X commented Oct 1, 2024

closes #8

Screenshot 2024-10-01 at 18 33 05

@Ugo-X
Copy link
Author

Ugo-X commented Oct 1, 2024

@ElliotFriend please look through this draft PR

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, there @Ugo-X!! Thanks for taking on this PR! I think you're on the right track! Looks like there's still some functionality and work you've got left in front of you, but I think you're headed in the right direction.

There may be some differences in the available functions from the most recent version of @stellar/stellar-sdk, which might affect some of the notes I left you. #23 will be upgrading that package to v12.3.0, so even if you need to incorporate that update into this PR, it'll be a package-wide change soon.

Edit: I just merged #23 into main, so just merge that back into your branch and yarn install again, and you should be set!

src/lib/utils/contractUtils.js Outdated Show resolved Hide resolved
src/lib/utils/contractUtils.js Outdated Show resolved Hide resolved
src/lib/stores/contractStore.js Outdated Show resolved Hide resolved
@Ugo-X
Copy link
Author

Ugo-X commented Oct 9, 2024

Screenshot 2024-10-09 at 15 52 22

i've fixed the comments and used the new methods as you indicated but i'm getting this error when i run the app

@Ugo-X Ugo-X marked this pull request as ready for review October 9, 2024 15:00
@Ugo-X
Copy link
Author

Ugo-X commented Oct 9, 2024

@ElliotFriend please look through this PR

@ElliotFriend
Copy link
Contributor

@Ugo-X Thanks for pointing out that error! Looks like this is my fault (from b136432), when I was trying to fix a build failure. Lemme get this worked out and I'll let you know how it comes along

@Ugo-X
Copy link
Author

Ugo-X commented Oct 14, 2024

@Ugo-X Thanks for pointing out that error! Looks like this is my fault (from b136432), when I was trying to fix a build failure. Lemme get this worked out and I'll let you know how it comes along

alright, thanks chief, will be waiting for a response.

@ElliotFriend
Copy link
Contributor

@Ugo-X I think I got this worked out. removed an old rollup configuration, and now we "should" be all set for both build/dev environments. Give it another shot, and let me know how it gets on.

@Ugo-X
Copy link
Author

Ugo-X commented Oct 14, 2024

@Ugo-X I think I got this worked out. removed an old rollup configuration, and now we "should" be all set for both build/dev environments. Give it another shot, and let me know how it gets on.

alright ser

@Ugo-X
Copy link
Author

Ugo-X commented Oct 23, 2024

@ElliotFriend please review again ser

@Ugo-X
Copy link
Author

Ugo-X commented Oct 24, 2024

@ElliotFriend please review again ser

🫠

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty good start! I left some feedback throughout.

I think the next step for you is to work out actually using the contract client after someone has saved/loaded/etc. a smart contract address.

Let me know if you have any trouble or questions. Thanks!

src/lib/stores/contractStore.js Outdated Show resolved Hide resolved
src/lib/stores/contractStore.js Outdated Show resolved Hide resolved
src/routes/dashboard/contracts/+page.svelte Outdated Show resolved Hide resolved
src/routes/dashboard/contracts/+page.svelte Outdated Show resolved Hide resolved
src/lib/stores/contractStore.js Outdated Show resolved Hide resolved
src/lib/stores/contractStore.js Outdated Show resolved Hide resolved
src/lib/utils/contractUtils.js Show resolved Hide resolved
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable interactions with smart contracts
2 participants