Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add details_json field to eho tables #67

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Jul 24, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the docs and README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/* , feature/* or patch/* .

What

Bring in the new details_json field for eho tables

Why

Change to support stellar/stellar-etl#270

Known limitations

  • Missing docs
  • Need to rename branch

@chowbao chowbao requested a review from a team as a code owner July 24, 2024 15:54
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update the .yml files to include new field addition? Take or leave the suggestion

@chowbao
Copy link
Contributor Author

chowbao commented Jul 24, 2024

nit: update the .yml files to include new field addition? Take or leave the suggestion

Yeah I was lazy and didn't update any of the .ymls yet. Will do after I've tested it

@chowbao chowbao merged commit 06283c9 into master Jul 30, 2024
3 checks passed
@sydneynotthecity sydneynotthecity deleted the add-json-to-history-operations branch November 14, 2024 16:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants