Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add json field to history_operations #448

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Jul 24, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository.

What

Add json field for details to history_operations

Why

Change to support stellar/stellar-etl#270

Known limitations

  • Need to test in test-hubble

@chowbao chowbao requested a review from a team as a code owner July 24, 2024 15:49
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt about also adding changes to the enriched_history_operations SQL? I think Securrency still uses that table as a source.

Also do you mind sneaking in a change to disable relevant asset trades? This would snooze the data quality alerts we're getting due to the bad SCD 2 # table

@chowbao
Copy link
Contributor Author

chowbao commented Jul 25, 2024

wdyt about also adding changes to the enriched_history_operations SQL? I think Securrency still uses that table as a source.

I don't think we should. I would rather them point to the new dbt eho table.

Also do you mind sneaking in a change to disable relevant asset trades? This would snooze the data quality alerts we're getting due to the bad SCD 2 # table

Yeah I can add that

@chowbao chowbao merged commit 4e86886 into master Jul 26, 2024
4 of 5 checks passed
@amishas157 amishas157 deleted the add-json-to-history-operations branch July 26, 2024 18:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants