Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[412 and 408 HUBBLE ] - Automated linting #257

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Conversation

laysabit
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the docs and the README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/* , feature/* or patch/* .

What

This PR is part of the scope " Make github workflow checks more consistent between all data repos" and " Data repos should all run prettier or some kind of automated linting "

Why

To have a pattern in the data repositories for linting and tests.

Known limitations

[N/A]

@laysabit laysabit marked this pull request as ready for review June 20, 2024 22:06
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laysabit laysabit merged commit 3825a6e into master Jun 24, 2024
7 checks passed
@laysabit laysabit deleted the feature/CI-improv branch July 1, 2024 15:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants