refactor: ♻️ add contained_doses variable to output
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aastedet
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Nice!
I'm not sure how the has_gld_purchases logical variable will be needed/used, but I look forward to finding out 😄
Once functions for censoring PCOS and GDM have been implemented, we'll need to revisit include_gld_purchases() and add them here. We'll probably also need to expand the tests for the function at that point.
signekb
approved these changes
Feb 10, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the documentation update, this adds the variable
contained_dosesfrom the multiplication of volume and apkWill not build correctly, since it depends on #185
Checklist
just run-all