Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Autogen.sh on deficient filesystems #414

Closed
oldfaber opened this issue Dec 12, 2017 · 1 comment
Closed

Autogen.sh on deficient filesystems #414

oldfaber opened this issue Dec 12, 2017 · 1 comment

Comments

@oldfaber
Copy link
Contributor

Commit fe705b8 forced autoreconf to always create symlinks, but some deficient filesystems,
cannot create them, and autoreconf fails on a linux VM where the git repository is on vboxfs.

I added an ugly workaround to autogen.sh, more or less doing

do_symlink=
ln -s xxx xxx-link > /dev/null 2>&1
RC=$?
if [ $RC -eq 0 ]; then
    do_symlink=--symlink
fi
# clean up
if autoreconf --install $do_symlink --force; then

Can this be added to the library or an option to autogen.sh is better ?

Thanks
Fabio

@mhei
Copy link
Contributor

mhei commented Dec 12, 2017

I vote for no option for autogen.sh. Could we change the test like this:

do_symlink=
if ln -s xxx xxx-link > /dev/null 2>&1; then
    do_symlink=--symlink
    rm xxx-link
fi
# clean up
if autoreconf --install $do_symlink --force; then

This looks better (at least for me 😄 ) and also removes the test link after the test.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants