Remove redundant check and guard debug output #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhei
force-pushed
the
remove-redundant-max-reg-check
branch
from
d89f16e to
0c4b419
Compare
|
Stumbled over this old PR; issues are still present, so I've rebased and updated it. |
|
Any reason to not merge this? |
We have the same check already in exported functions modbus_read_registers and modbus_read_input_registers which both calls out to the internal static function read_registers. So we can safely remove this redundant check in read_registers. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
mhei
force-pushed
the
remove-redundant-max-reg-check
branch
from
0c4b419 to
7b1409c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found two minor issues:
print error message only when debug output is enabled to be consistent with other functionsEdit: updated description after force-push (second issue was meanwhile fixed, so I dropped the commit)