Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Added prop for fontScaling for allowing font scale (#358 & #349) #362

Merged
merged 9 commits into from
Jan 29, 2024

Conversation

SanyaPillai
Copy link
Contributor

Added prop for font scaling for enabling and disabling font scaling in calendar picker.

@tranjog
Copy link
Contributor

tranjog commented Jan 22, 2024

Thanks @SanyaPillai! This looks like a good addition to the library.
Could you please update the version number in package.json to 8.0.1?

@peacechen
Looks good to me 👍

@peacechen
Copy link
Collaborator

Thanks @SanyaPillai
Please update the Readme with the new prop

@SanyaPillai
Copy link
Contributor Author

@tranjog and @peacechen Updated the PR as per the comments added

CalendarPicker/index.js Outdated Show resolved Hide resolved
@peacechen
Copy link
Collaborator

Thanks @SanyaPillai
Upon review, I spotted performance and readability change that should be made.

@SanyaPillai
Copy link
Contributor Author

@peacechen ,
I have made the changes to PR as per the comment for imporving readability and performance

Screenshot 2024-01-29 at 10 58 40 AM

@peacechen
Copy link
Collaborator

Thanks @SanyaPillai
@tranjog Would you like to publish this version?

@peacechen peacechen merged commit 966619d into stephy:master Jan 29, 2024
@tranjog
Copy link
Contributor

tranjog commented Jan 29, 2024

Thanks both, 8.0.1 has been published:
https://www.npmjs.com/package/react-native-calendar-picker

@peacechen Please close these two:
#349
#358

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants