Skip to content

Deliberate blocking UploadAndSerial() hack #53

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Conversation

elig0n
Copy link
Contributor

@elig0n elig0n commented Nov 21, 2022

Referencing Issue #52

2 possible considerations:

  • Would it be better to get back to original terminal setting before the call to Serial() ?
  • Could an abort rising error prevent TERM from resetting ?

@elig0n elig0n changed the title Deliberate blocking UploadAndSerial() implementation Deliberate blocking UploadAndSerial() hack Nov 21, 2022
Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, temporarily setting the script variable is kind of a terrible hack, but I don't see an easy way to do it better.

If you remove the abort from the function, I believe that should fix the issue where an error would mess up the state of the s:TERM.

Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stevearc stevearc merged commit 4651b71 into stevearc:master Nov 22, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants