A few changes #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 8, 2013 12:16
…creating a new object. This way a long-running Lua thread won't cause the garbage collector to time out blocking on synchronized(L).
|
Finalization of Lua objects is something that's been hitting me on long network requests, I'll be testing this out myself as well - thanks! |
|
what's the status on this being accepted? |
|
Soon, I promise you. On Sun, Nov 30, 2014 at 12:14 AM, CameraCornet notifications@github.com
|
|
I'm not using AndroLua any more, so it's no skin off of my nose, but I was amused when I looked at my open pull requests to see the "Soon, I promise you." above. Oops. ¯\(ツ)/¯ |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the ability to use the # operator on arrays passed down from Java. It's a pretty simple change, and I've tested it and it works.
I also needed LuaObject.finalize() to not block on synchronized(L).
As a bonus, I hate seeing warnings, so I found the GCC pragma that asks it to ignore the warnings in question, as well as cleaning up the warnings in LuaObject.
I also have extensions allowing LuaJava to access LuaJIT's FFI. Let me know if you're interested in adding that; FFI is awesome, and works on Android to pull in and link with .so files (as well as standard C library functions, of course -- I got rid of several calls into Java entirely by using FFI calls into C libraries, which is just all kinds of faster).
--Tim