Skip to content

Commit

Permalink
(chocolatey#2899) Address PR feedback
Browse files Browse the repository at this point in the history
Add link to new issue in TODO block for handling multiple package ids
in the info command

Call because() method directly in tests, as we've done the setup there

Remove Exception decorator from error variable in tests
  • Loading branch information
steviecoaster committed Nov 14, 2022
1 parent 2a78b94 commit 8a7d979
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public void show_throw_when_package_id_is_not_set()

try
{
command.handle_validation(configuration);
because();
}
catch (Exception ex)
{
Expand All @@ -173,11 +173,11 @@ public void show_throw_when_package_id_is_not_set()
public void should_throw_when_multiple_package_ids_set()
{
configuration.Input = "foo bar";
Exception error = null;
error = null;

try
{
command.handle_validation(configuration);
because();
}
catch (Exception ex)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public override void handle_validation(ChocolateyConfiguration configuration)
}

//Validate only a single package has been passed to info
//TODO: Provide ability to get info on a list of packages
//TODO: Provide ability to get info on a list of packages. See https://github.com/chocolatey/choco/issues/2905
string[] input = configuration.Input.Split(' ');
if (input.Count() > 1)
{
Expand Down

0 comments on commit 8a7d979

Please # to comment.