Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixes Android Border leaking #61

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Fixes Android Border leaking #61

merged 1 commit into from
Nov 6, 2019

Conversation

memsranga
Copy link
Contributor

Fixes #34

@sthewissen sthewissen merged commit ce07be0 into sthewissen:master Nov 6, 2019
@mister-giga
Copy link

Hello,
To make 40x40 sized PancakeView round on android the value 20 for corner radius is not enough anymore. Setting to 40 makes it round.

@sthewissen
Copy link
Owner

Hm, that does seem like an unfortunate side effect of this. I will revert these changes for now.

sthewissen added a commit that referenced this pull request Nov 11, 2019
@sthewissen
Fixes a few bugs
d65b7b7 
- Fixes cornerradius regressing due to #61
- Fixes Elevation for Android < API21
@sthewissen sthewissen mentioned this pull request Nov 11, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sthewissen sthewissen sthewissen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Droid] Improve rendering of background/border
3 participants
@memsranga @mister-giga @sthewissen