Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor JSONPointerTest #631

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Refactor JSONPointerTest #631

merged 3 commits into from
Oct 14, 2021

Conversation

sreekesh93
Copy link
Contributor

@sreekesh93 sreekesh93 commented Oct 11, 2021 •
edited
Loading

Refactor the existing JSONPointer unit test with explicitly mentioning the expected values.

@sreekesh93 sreekesh93 mentioned this pull request Oct 11, 2021
Closed
johnjaylward
johnjaylward suggested changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@johnjaylward johnjaylward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the full document compare, it's best to use the JSONObject.similar method:

assertTrue(new JSONObject(EXPECTED_COMPLETE_DOCUMENT).similar(actualObject));

@sreekesh93
Copy link
Contributor Author

sreekesh93 commented Oct 11, 2021 •
edited
Loading 

assertTrue(new JSONObject(EXPECTED_COMPLETE_DOCUMENT).similar(actualObject));

Thanks ,Updated the changes

@stleary
Copy link
Owner

stleary commented Oct 12, 2021

What problem does this code solve?
Fixes #590 Need to complete unit tests for JSONPointer

Risks
Low, this only affects the unit tests

Changes to the API?
N/A

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
No

Review status
APPROVED

@stleary
Copy link
Owner

stleary commented Oct 12, 2021

Starting 3 day comment window

@stleary stleary merged commit 4e601fd into stleary:master Oct 14, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@johnjaylward johnjaylward johnjaylward approved these changes

Assignees
No one assigned
Labels
Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreekesh93 @stleary @johnjaylward