-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Strict mode unit tests #938
Conversation
@Simulant87 Please remove JSONArray, JSONObject, and JSONTokener as these have been merged in #937. The new unit tests may be kept. |
This reverts commit afd9a6f.
I updated the branch, and it only contains missing JavaDoc and the new test cases now. |
What problem does this code solve? Does the code still compile with Java6? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status |
Taken the changes from #937 preserving an attribution history of the authors commits:
In addition:
New unit tests for Strict mode using JSONTokener and JSONParserConfiguration #934
Bugfix: NullPointerException thrown for invalid input on JSONTokener without strict mode #936
this can be taken as a discussion baseline, or merged instead or after #937 and makes #934 and #936 obsolete