Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update for new pac #511

Closed
wants to merge 15 commits into from
Closed

Conversation

usbalbin
Copy link
Member

@usbalbin usbalbin commented Dec 5, 2024

This updates this hal to use the stm32h7-staging pac. I am doing this in an attempt to get the HRTIM peripheral to work.

Also, some other hals seems to be moving towards staging pacs aswell. Not sure whats best...

@usbalbin usbalbin force-pushed the update_for_new_pac branch 2 times, most recently from afd5dfa to 283459f Compare December 6, 2024 10:39
@usbalbin usbalbin mentioned this pull request Dec 6, 2024
14 tasks
@usbalbin usbalbin force-pushed the update_for_new_pac branch 2 times, most recently from 29a1d10 to bd09207 Compare December 14, 2024 15:15
@usbalbin usbalbin changed the title [Experiment]Update for new pac Update for new pac Dec 15, 2024
@usbalbin usbalbin marked this pull request as ready for review December 16, 2024 22:01
@usbalbin
Copy link
Member Author

@richardeoin here is an attempt at updating the pac. This is needed for using the HRTIM perpheral since there are a lot of errors in the SVD's that have recently been patched. I also believe there has been other improvements such as allowing things like this:

- (*Gpio::<P>::ptr()).pupdr.modify(|r, w| {
-     w.bits((r.bits() & !(0b11 << offset)) | (value << offset))
- });
+ (*Gpio::<P>::ptr())
+     .pupdr()
+     .modify(|_, w| w.pupdr(offset).bits(value));

and likely many other things which I have not yet updated the code for.

Do you want this change? I also understand if you dont wish to move away from the official releases.

@richardeoin
Copy link
Member

Awesome work. It's great to keep up with the updates to the PAC. Looks like stm32h7-staging is release channel made by @burrbull , I guess to encourage downstream testing before an 'official' stm32h7 PAC release?

I'd be happy to use the -staging PAC on a branch in this repo. That would allow more PRs to be built on top of it.

@richardeoin
Copy link
Member

I created the pac16-staging branch on the repo. You can now make PRs against that branch instead of master.

@usbalbin
Copy link
Member Author

Great thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants