Skip to content

Arduino cli fix #1018

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Mar 28, 2020
Merged

Arduino cli fix #1018

merged 2 commits into from
Mar 28, 2020

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Mar 28, 2020

It fixes the issue raised here arduino/arduino-cli#355

Following the documentation
https://arduino.github.io/arduino-cli/platform-specification/#recipes-to-export-compiled-binary

Only one recipe.output.tmp_file and recipe.output.save_file should be defined. The ".bin" only should be copied.
Now upload with arduino-cli works as "Export compiled Binary".

fpistm added 2 commits March 28, 2020 11:55
The folder is the sketch and it is the path to that folder that
should specify as the argument to arduino-cli.
Because a sketch may consist of multiple files. All source files
in the sketch folder are compiled.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Issue raised here arduino/arduino-cli#355

Following the documentation
https://arduino.github.io/arduino-cli/platform-specification/#recipes-to-export-compiled-binary

Only one recipe.output.tmp_file and recipe.output.save_file should
be defined. The ".bin" only should be copied.
Now upload with arduino-cli works as "Export compiled Binary"

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Copy link
Contributor

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only looked at the platform.txt commit, not the CI commit, and did not test anything, though.

@fpistm fpistm merged commit 6aa5ee9 into stm32duino:master Mar 28, 2020
@fpistm fpistm deleted the arduino-cli-fix branch March 28, 2020 15:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request fix 🩹 Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants