Skip to content

config: add debug information menu #1446

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jul 13, 2021

This PR add a new menu Debug information.
By default it is not enabled. Enable it will produce debugging information.

image

It also fix the Optimize menu which displayed Debug (-g) instead of "Debug (-Og)".

Fixes #873

For further reading: https://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html#Debugging-Options

/CC @matthijskooijman

@fpistm fpistm added the enhancement New feature or request label Jul 13, 2021
@fpistm fpistm added this to the 2.1.0 milestone Jul 13, 2021
@matthijskooijman
Copy link
Contributor

Patch looks good to me. Maybe name it "Debug symbols" instead of "Debug information"? I can imagine the latter makes people expect that additional debug info will be printed?

@fpistm
Copy link
Member Author

fpistm commented Jul 14, 2021

Thanks @matthijskooijman for your feedback.
I agree with you, information can be confusing even if it's purely the name used by gcc for the debugging options.
I will do the change.

Fixes stm32duino#873

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm merged commit 96955e2 into stm32duino:master Jul 14, 2021
@fpistm fpistm deleted the debug_menu branch July 14, 2021 17:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: Enable -g on all builds
2 participants