Skip to content

chore: Incorporate ST feedback #1844

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 5, 2022
Merged

chore: Incorporate ST feedback #1844

merged 1 commit into from
Oct 5, 2022

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Oct 4, 2022

Clarify Swan LP1 interface defines.

We liked/appreciated your feedback, but we didn't get it changed before you merged.
Thank you for your quick responses, and good advice. ;-)

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm added the enhancement New feature or request label Oct 4, 2022
@fpistm fpistm added this to the 2.4.0 milestone Oct 4, 2022
@fpistm
Copy link
Member

fpistm commented Oct 4, 2022

We liked/appreciated your feedback, but we didn't get it changed before you merged.
Thank you for your quick responses, and good advice. ;-)

You didn't tell me you would make change 😛

@zfields
Copy link
Contributor Author

zfields commented Oct 5, 2022

I thought I was fast, but you were faster... 😝

This one is ready when you are. 👍

@fpistm fpistm merged commit ed4ef2f into stm32duino:main Oct 5, 2022
@zfields zfields deleted the swan_vcp branch February 28, 2023 20:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants