-
Notifications
You must be signed in to change notification settings - Fork 1k
Add RAK3172 module #2005
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add RAK3172 module #2005
Conversation
Hi @Oliv4945 |
Thanks @fpistm, I moved it. |
Well while the new release including the board is not released I put it in yellow and moved to green when officially released. |
Ok, updated |
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_RAK3172_MODULE.h
Outdated
Show resolved
Hide resolved
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_RAK3172_MODULE.h
Outdated
Show resolved
Hide resolved
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_RAK3172_MODULE.h
Outdated
Show resolved
Hide resolved
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_RAK3172_MODULE.cpp
Outdated
Show resolved
Hide resolved
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_RAK3172_MODULE.cpp
Outdated
Show resolved
Hide resolved
Here the patch, if it helps. |
Wow, thanks @fpistm and sorry for the mistakes. I have been mislead by another document with some other errors that I reported to RAK. I agree with all your changes except for PB5: unless I am using the wrong datasheet there is no ADC I order to avoid any further error also doubled checked the PIN definition with their RUI BSP |
Oups, you are right. PB5 has no ADC as defined in the generic: Arduino_Core_STM32/variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_generic.h Lines 28 to 38 in 31e562d
Please fix. |
Could you rebase on top of the main as it seems there are some conflits. |
Thanks, I applied your patch |
Ok, I just did but I did not saw any conflicts |
You don't rebase you do a merge.
|
029f9d6
to
3874dac
Compare
Right I am more used to merge sorry :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Oliv4945
LGTM. Nice contribution.
I've not tested as I don't have the RAK module but variant is correctly defined.
Summary
This PR implements RAK3172 module bases on STM32WLE5CCU
As discussed the LoRaWAN repo (stm32duino/STM32LoRaWAN#13) it is cleaner to add it here.
This is still a draft as I did not update the main Readme because of a question: I created the section
LoRa modules
, but is it correct? If not, should I place it in theLoRa
boards instead?Validation