Skip to content

feat: Blues Cygnet #2399

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jun 14, 2024
Merged

feat: Blues Cygnet #2399

merged 3 commits into from
Jun 14, 2024

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Jun 12, 2024

Refactor Blues Wireless to Blues
Define Cygnet
Improvements to Swan

The bad link (in the checks), is our reserved page for this product.

@zfields
Copy link
Contributor Author

zfields commented Jun 12, 2024

This migrates the Ray's original Cygnet work to the STM32L433CCT6, and incorporates many suggestions from @fpistm's code review.

@fpistm Can you please sanity check this work. This is my first time making significant modifications to the board definition.

@fpistm fpistm self-requested a review June 13, 2024 06:48
@fpistm fpistm added the new variant Add support of new bard label Jun 13, 2024
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zfields
Thanks for the updated PR.
Just on remarks about the link even if reserved on your side I would prefer add it when really available to avoid further support because one link does not exist and not related to other PR.

@zfields
Copy link
Contributor Author

zfields commented Jun 13, 2024

@fpistm I've adopted your change. 👍 Thank you for your help! ❤️

@fpistm fpistm self-requested a review June 14, 2024 06:56
@fpistm fpistm added this to the 2.8.0 milestone Jun 14, 2024
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zfields
I've squash some commits to be more clean.
LGTM

@fpistm fpistm merged commit 7efecbf into stm32duino:main Jun 14, 2024
24 checks passed
@zfields zfields deleted the cygnet branch June 14, 2024 14:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
new variant Add support of new bard
Projects
Development

Successfully merging this pull request may close these issues.

2 participants