Skip to content

feat: Add variant NUCLEO-C071RB #2558

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 14, 2024
Merged

feat: Add variant NUCLEO-C071RB #2558

merged 4 commits into from
Nov 14, 2024

Conversation

thernstig
Copy link
Contributor

Fixes #2537

@thernstig
Copy link
Contributor Author

@fpistm I have NO idea if this is correct. I could not find any guideline on how to do for Nucleos. I took a look at https://github.com/stm32duino/Arduino_Core_STM32/pull/1745/files when doign this.

It seems I should have done changes in the variant_NUCLEO_C071RB.cpp and variant_NUCLEO_C071RB.h files in some way, that I probably got wrong.

I am completely ok with you updating anything in this commit manually.

I have no idea how to test it.

@fpistm fpistm added the new variant Add support of new bard label Nov 12, 2024
@fpistm fpistm added this to the 2.9.0 milestone Nov 12, 2024
@fpistm fpistm self-requested a review November 12, 2024 15:43
@fpistm
Copy link
Member

fpistm commented Nov 13, 2024

Hi @thernstig
Could you rebase this PR on the main.
It requires to get the generic to be able to build (ldscript.ld).

@thernstig
Copy link
Contributor Author

@fpistm Rebase done.

Are any updates needed in the .cpp and .h file? I have no idea what is needed there.

@fpistm
Copy link
Member

fpistm commented Nov 13, 2024

@thernstig
I will review this afternoon. I will made the change.

@fpistm
Copy link
Member

fpistm commented Nov 13, 2024

@thernstig
I've updated your branch.

  • fix astyle issue
  • order the pins to match board pinout (mainly Arduino Uno connector) and set the analog pins order.
  • Define the USER_BTN, LED,...
  • Add the USB support since STM32C071xx support USB. (not tested, only build enable)

@fpistm fpistm mentioned this pull request Nov 13, 2024
Open
85 tasks
fpistm
fpistm approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thernstig and others added 4 commits November 14, 2024 07:57
@thernstig @fpistm
feat: add variant NUCLEO-C071RB
77f551d 
Fixes stm32duino#2537

Signed-off-by: thernstig <30827238+thernstig@users.noreply.github.com>
@fpistm
fix(c0): add missing HAL HCD and PCD modules
476a435 
See STMicroelectronics/stm32c0xx-hal-driver#1

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
chore(c0): define USB_IRQn
cced92b 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
chore(cmake): update with new Nucleo C071RB
deaab3c 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@thernstig
Copy link
Contributor Author

thernstig commented Nov 14, 2024 •
edited
Loading

@fpistm thank you! If you think this looks ok I am ok to merge as well 🙂

Are you intending to release 2.9.0 soon 😄

@fpistm
Copy link
Member

fpistm commented Nov 14, 2024

Are you intending to release 2.9.0 soon

Yes, in the coming days, anyway think that I've not tested this PR as I do not have the board. Anyway, I'm confident that it should work. Only a doubt about USB as it is the first time deployed on STM32C0xx series.

@fpistm fpistm merged commit f919d8c into stm32duino:main Nov 14, 2024
25 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
new variant Add support of new bard
Projects
STM32 core based on ST HAL
Status: Done
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

[New Variant] NUCLEO-C071RB
2 participants
@thernstig @fpistm