fix(Wire): only recover bus when device is master #2758
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cparata
approved these changes
Jul 2, 2025
github-project-automation
bot
moved this from In progress
to Reviewer approved
in STM32 core based on ST HAL
github-project-automation
bot
moved this from Reviewer approved
to Done
in STM32 core based on ST HAL
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed an issue in Wire.begin() where the I2C bus recovery routine was always triggered, even when initializing as a slave device. This could lead to unintended manipulation of the SCL line while SDA is low - potentially during an active transmission from the master. Only the master should perform a bus recovery.
This PR fix ensures that the SCL line is not manipulated when Wire.begin() is called in slave mode.