Update neorv32_cpu_control.vhd #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, This change enables 64-bit counter to be implemented. The former formula zeros hpm_cnt_hi_width_c when HPM_CNT_WIDTH equals to 64 and the actual bit width of implemented counter is 32 in that case. Thanks Signed-off-by: mahdi259 <73544027+mahdi259@users.noreply.github.com>
|
Oh, thanks for the hint! I'll check that! The rather complex formula we were using here was menat to avoid a negative value for the high-counter width. But I cannot remeber why this was an isuue. 🙈 |
|
You're welcome. |
|
Indeed, this is a bug. Thanks for fixing! |
stnolting
approved these changes
Dec 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This change enables 64-bit counter to be implemented.
The former formula zeros hpm_cnt_hi_width_c when HPM_CNT_WIDTH equals to 64 and the actual bit width of implemented counter is 32 in that case. Thanks