Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🐛 [newlib] fix broken sbrk function #957

Merged
merged 5 commits into from
Jul 20, 2024
Merged

🐛 [newlib] fix broken sbrk function #957

merged 5 commits into from
Jul 20, 2024

Conversation

stnolting
Copy link
Owner

@stnolting stnolting commented Jul 20, 2024

A bug in the implementation of newlib's sbrk function caused malloc to always make memory available, even though the heap was already full. This caused a collision of heap and stack and finally a CPU crash.

  • 🐛 fixed bug in newlib's sbrk function; malloc works now as expected
  • ✨ add support for time() function

- check pointer returned by malloc
- add time function test
+ add support for time() function
+ massive cleanup
@stnolting stnolting added bug Something isn't working as expected enhancement New feature or request SW Software-related labels Jul 20, 2024
@stnolting stnolting self-assigned this Jul 20, 2024
@stnolting stnolting marked this pull request as ready for review July 20, 2024 19:48
@stnolting stnolting merged commit d0c45ab into main Jul 20, 2024
10 checks passed
@stnolting stnolting deleted the newlib_fix branch July 20, 2024 19:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working as expected enhancement New feature or request SW Software-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant