Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

RTL reworks, cleanups and optimizations #996

Merged
merged 16 commits into from
Aug 26, 2024
Merged

RTL reworks, cleanups and optimizations #996

merged 16 commits into from
Aug 26, 2024

Conversation

stnolting
Copy link
Owner

@stnolting stnolting commented Aug 25, 2024 •
edited
Loading

  • Vivado IP module: major rework; use explicit std_logic[_vector] <-> std_ulogic[_vector] conversion; remove VHDL2008 requirement (not supported by the IP packager?)
  • CPU: remove reset of output register of multiplier unit to improve mapping to DSP block (FAST_MUL_EN option only)
  • CPU: ⚠️ remove user-level HPMs
  • CPU: rework mcountern CSR; add explicit CY and IR bits
  • CPU: rework "next PC" logic - use ALU adder to compute the next instruction address (removes one carry chain and shortens the critical path of the base CPU core)
  • DOCs: updates, cleanups and fixes

stnolting added 12 commits August 23, 2024 01:32
@stnolting
[multiplier] remove output register reset
4bc0511 
to improve (Xilinx) DSP mapping (FAST_MUL option only)
@stnolting
[package] update version ID
1855f06
@stnolting
[vivado ip] clean up gui; remove VHDL08 attribute
f8be756 
also fixing #994
@stnolting
[vivado ip] explicitly convert types
d10d8e3 
std_ulogic[_vector] <-> std_logic[_vector]
@stnolting
⚠️ [cpu] remove user-level HPMs
9af76a4
@stnolting
[lib] remove user-level HPMs
16c2d65 
- minor cleanups
- add CSR reference link (doxagen)
- add mcounteren defines
@stnolting
[docs] CPU: minor edits
6cbd563
@stnolting
[docs] remove user-level HPMs; add mcounteren bits
2b6d5b9
@stnolting
[docs] CSR: minor fixes
a1c2353
@stnolting
[docs] minor typo fix
d004d51
@stnolting
[control] remove U-HPMs; rework mcountern
8a3e045 
- mcounteren: add individual CY and IR bits
- remove user-mode HPMs
@stnolting
[processor_check] update mcounteren test case
e5d831e
@stnolting stnolting added HW Hardware-related optimization Make things faster, smaller and more efficient cleanup Clean-up the codebase labels Aug 25, 2024
@stnolting stnolting self-assigned this Aug 25, 2024
@stnolting stnolting linked an issue Aug 25, 2024 that may be closed by this pull request
Typo in the IP block customisation #994
Closed
@stnolting
[changelog] add v1.10.2.8
a63e8c4
@stnolting
[imem] minor sanity check edit
bc097db
@stnolting
[control] use ALU.add for next PC computation
430e612 
use "ALU.add = PC + IMM" with Imm=2/4 for computing the next PC (saves one adder and reduces input count of the next PC input multiplexer)
@stnolting
[crc] replace tabs by spaces
4a56cca
@stnolting stnolting marked this pull request as ready for review August 25, 2024 16:42
Sam-Vervaeck
Sam-Vervaeck reviewed Aug 26, 2024
View reviewed changes
Copy link

@Sam-Vervaeck Sam-Vervaeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look through all the changes, did not see anything weird.

@stnolting
Copy link
Owner Author

@Sam-Vervaeck Thanks for reviewing! :)

I'm still doing some (synthesis) tests, but everything seems to be fine so far.

@stnolting stnolting merged commit ea709d5 into main Aug 26, 2024
10 checks passed
@stnolting stnolting deleted the dev240824 branch August 26, 2024 18:25
@Sam-Vervaeck
Copy link

@stnolting This is still in the user guide but I think this pull request removed the need for this disclaimer in section 12?
image

@stnolting
Copy link
Owner Author

You are right! I forgot to remove that... Thanks for pointing that out!

stnolting added a commit that referenced this pull request Aug 28, 2024
@stnolting
[docs] remove VHDL2008 statement from Vivado IP
7873e2e 
addition to #996
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Sam-Vervaeck Sam-Vervaeck Sam-Vervaeck left review comments

Assignees

@stnolting stnolting

Labels
cleanup Clean-up the codebase HW Hardware-related optimization Make things faster, smaller and more efficient
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in the IP block customisation
2 participants
@stnolting @Sam-Vervaeck