Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

flaky test #102

Closed
wants to merge 1 commit into from
Closed

flaky test #102

wants to merge 1 commit into from

Conversation

volmedo
Copy link
Member

@volmedo volmedo commented Jan 31, 2025

No description provided.

@volmedo volmedo self-assigned this Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/aws/bucketfallbackmapper.go 83.33% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
pkg/aws/bucketfallbackmapper.go 81.48% <83.33%> (-0.16%) ⬇️

... and 1 file with indirect coverage changes

@volmedo volmedo closed this Feb 1, 2025
@volmedo volmedo deleted the vic/test/flaky-test branch February 1, 2025 20:32
@volmedo
Copy link
Member Author

volmedo commented Feb 1, 2025

the traces show the issue was a race condition starting the server and running the test (see this failing run of the test).

the solution is implemented in #104

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant