fix: allow skipping publish of existing advert #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
volmedo
reviewed
Feb 11, 2025
| @@ -36,6 +38,7 @@ type ProviderIndexService struct { | |||
| findClient ipnifind.Finder | |||
| publisher publisher.Publisher | |||
| legacyClaims LegacyClaimsFinder | |||
| mutex *sync.Mutex | |||
There was a problem hiding this comment.
I'd use a plain sync.Mutex here rather than the pointer.
| @@ -46,6 +49,7 @@ func New(providerStore types.ProviderStore, findClient ipnifind.Finder, publishe | |||
| findClient: findClient, | |||
| publisher: publisher, | |||
| legacyClaims: legacyClaims, | |||
| mutex: &sync.Mutex{}, | |||
There was a problem hiding this comment.
and skip its initialization as the default value already provides a usable mutex
Co-authored-by: Vicente Olmedo <vicente@storacha.network>
volmedo
approved these changes
Feb 11, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one or multiple users upload the same blob multiple times the
assert/indexinvocation will create an advert that already exists. This will causeipni-publisherto returnErrAlreadyAdvertisedand the invocation fails. This PR ignoresErrAlreadyAdvertisedbecause, that's fine, whatever.It also adds a mutex around publish per storacha/ipni-publisher#3