Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: error code on query failure #59

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

alanshaw
Copy link
Member

Any error returned from the query engine is a server error - we've already validated the client sent parameters, it's no longer possible for the request to be considered bad.

I also switched magic constant 400 out for http.StatusBadRequest for readability.

@alanshaw alanshaw requested a review from volmedo December 13, 2024 12:26
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/server/server.go 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
pkg/server/server.go 17.82% <0.00%> (ø)

... and 1 file with indirect coverage changes

@alanshaw alanshaw merged commit 9f1342f into main Dec 13, 2024
7 of 8 checks passed
@alanshaw alanshaw deleted the fix/error-code-on-query-failure branch December 13, 2024 12:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants