Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: make no-op legacy claims finder comply with interface expectations #60

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix: make no-op legacy claims finder comply with interface expectations #60

merged 1 commit into from
Dec 16, 2024

Conversation

volmedo
Copy link
Member

@volmedo volmedo commented Dec 16, 2024

Implementations should return an empty results slice when no results are found, rather than type.ErrKeyNotFound error.

@volmedo volmedo requested a review from alanshaw December 16, 2024 13:53
@volmedo volmedo self-assigned this Dec 16, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/service/providerindex/legacy.go 0.00% 4 Missing ⚠️
pkg/construct/construct.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pkg/construct/construct.go 0.00% <0.00%> (ø)
pkg/service/providerindex/legacy.go 72.88% <0.00%> (ø)

@volmedo volmedo merged commit fab8d75 into main Dec 16, 2024
7 of 8 checks passed
@volmedo volmedo deleted the vic/fix/no-results-legacy-finder branch December 16, 2024 16:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees

@volmedo volmedo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volmedo @alanshaw