Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore(publish-equals-claim): add unit tests for Publish Equals Claim functionality #95

Merged
merged 6 commits into from
Jan 22, 2025
Merged

chore(publish-equals-claim): add unit tests for Publish Equals Claim functionality #95

merged 6 commits into from
Jan 22, 2025

Conversation

fforbeck
Copy link
Member

@fforbeck fforbeck commented Jan 22, 2025 •
edited
Loading

Test Cases

  • Successfully publishes a claim
  • Error when reading caveats fails
  • Error when publishing claim in claims service fails
  • Error when publishing claim in provider index fails
  • Correctly handles a claim with expiration

Minor Changes

  • Added a new target to the makefile to run tests without cache
  • Added codecov config to ignore mock files
  • Fixed some error messages

Resolves storacha/project-tracking#169

@fforbeck fforbeck self-assigned this Jan 22, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
pkg/service/service.go 80.93% <100.00%> (+9.73%) ⬆️

... and 12 files with indirect coverage changes

@fforbeck fforbeck marked this pull request as ready for review January 22, 2025 16:31
@fforbeck fforbeck merged commit ab9f048 into main Jan 22, 2025
9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

@volmedo volmedo Awaiting requested review from volmedo

@hannahhoward hannahhoward Awaiting requested review from hannahhoward

@travis travis Awaiting requested review from travis

Assignees

@fforbeck fforbeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish equals claim
2 participants
@fforbeck @alanshaw