chore: use ipfs-unixfs final release instead of fork #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
chore/use-unixfs
branch
from
1568d0e to
dad82ce
Compare
BREAKING CHANGE: We rely now on an extended version of the new ipfs blockstore interface to be compatible with the new ipfs-unixfs. Previously unixfs was using a simple block API from ipld which returned blocks everywhere, while now put returns a void Promise and get returns the bytes instead of the Block. Destroy was also renamed to close to be the same as the interface. The only addition in the interface is the blocks async iterator function. All the blocktore implementations extend BlockstoreAdapter to have all the API expected by the interface.
vasco-santos
force-pushed
the
chore/use-unixfs
branch
from
acda337 to
801dc6d
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the ipfs-unixfs final release instead of our own fork. Includes changes to fulfil the new Blockstore API expected by unixfs and a new
VerifyingGetOnlyBlockStoreclass to avoid type complains from unixfs expectations.This PR also updated the dependencies.
BREAKING CHANGE: We rely now on an extended version of the new ipfs blockstore interface to be compatible with the new ipfs-unixfs. Previously unixfs was using a simple block API from ipld which returned blocks everywhere, while now put returns a void Promise and get returns the bytes instead of the Block. Destroy was also renamed to close to be the same as the interface. The only addition in the interface is the blocks async iterator function. All the blocktore implementations extend BlockstoreAdapter to have all the API expected by the interface.