feat: add support for large file encryption #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
LGTM this is a great add.
To check, are you able to do a roundtrip upload/download with a large file with the two scripts we have?
Also we don't yet have tests -- we should start thinking about that.
Overall though excellent adds to the existing functionality!
|
|
||
| const fileContent = await fs.readFile(filePath) | ||
| let blob = new Blob([fileContent]) | ||
| // Generate a random symmetric key and initialization vector |
There was a problem hiding this comment.
where is this taken from? just want to make sure we're following well established patterns for any encryption we're doing
There was a problem hiding this comment.
Oh, so this is how the Lit team recommends handling double encryption.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the objectives outlined in the issue storacha/project-tracking#315
Please refer to the issue for a detailed context.