test: add unit testing for pdp package #43
Conversation
- add testutil for creating pieces
- generated mocks as required for testing
| { | ||
| name: "Single piece >256MB (if code permits) => immediate flush or error", | ||
| // TODO(forrest): do we expect this to be an error case? | ||
| // The aggregator code comment suggests >256MB is out-of-scope, but not | ||
| // strictly enforced. Some implementations could treat this | ||
| // as an error or just flush. | ||
| pieceSizes: []int64{300 * MB}, | ||
| expectedBufferSize: 0, | ||
| expectedAggCount: 1, |
There was a problem hiding this comment.
Unsure if this case is realistic, AggregatePieces states a pieces should never be larger than 256MB, but doesn't enforce the constraint.
| func WithAggregator(a BufferedAggregator) PieceAggregatorOption { | ||
| return func(pa *PieceAggregator) { | ||
| pa.aggregator = a | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Allows the aggregator implementation to be subbed out for a mock in testing.
| @@ -0,0 +1,166 @@ | |||
| package aggregator_test | |||
There was a problem hiding this comment.
Seeking opinions on testing strategy here. So much of this is mocked that all we are really doing is asserting the right methods are called in the right order. While this add some value, my feeling is an integration/system test would be more useful here, ideally ad a higher level in the call stack.
| @@ -15,6 +15,20 @@ import ( | |||
| "github.com/storacha/go-ucanto/principal" | |||
| ) | |||
|
|
|||
| type PDPClient interface { | |||
There was a problem hiding this comment.
Defined interface for Curio client, allowing it to be mocked in curiofinder_test and curioadder_test.
What
How to Review
Each commit is reviewable on it's own.