Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix linting and typechecking to match how we do in w3protocol. #296

Closed
olizilla opened this issue Jan 26, 2023 · 0 comments · Fixed by #380
Closed

Fix linting and typechecking to match how we do in w3protocol. #296

olizilla opened this issue Jan 26, 2023 · 0 comments · Fixed by #380
Assignees
@travis

Comments

@olizilla
Copy link
Contributor

ts-standard is not standard... it's significantly more opinionated, and a bit of a drain to work with.

Out of numerous discussions on the subject over there years we eventually agreed to adopt the @hugomrdias method for (es)linting, prettiering and typechecking as demonstrated in w3protocol. this repo was started before that agreement, but we should take a moment to bring it inline with the current norms, lest it be just another repos with it's own way of doing things.
@travis travis self-assigned this Feb 7, 2023
travis added a commit that referenced this issue Feb 7, 2023
@travis
chore: update linter, prettier configs
6d0b623 
Per #296, update linter configs and install prettier to match https://github.com/web3-storage/w3protocol

Use @hugomrdias's `hd-scripts` configs, but turn off a few eslint
rules that either a) I didn't like (no-negated-conditions, no-null) or
feel duplicative in TypeScript (all of the jsdoc rules). Also turn off
`import/extensions` because as far as I can tell it recommends the wrong
thing.

This commit doesn't include changes that prettier would make - adding
another commit for this to keep things easy to review.
@travis travis mentioned this issue Feb 7, 2023
Merged
@travis travis linked a pull request Feb 7, 2023 that will close this issue
chore: update linter, prettier configs #380
Merged
travis added a commit that referenced this issue Feb 7, 2023
@travis
chore: update linter, prettier configs
b204000 
Per #296, update linter configs and install prettier to match https://github.com/web3-storage/w3protocol

Use @hugomrdias's `hd-scripts` configs, but turn off a few eslint
rules that either a) I didn't like (no-negated-conditions, no-null) or
feel duplicative in TypeScript (all of the jsdoc rules). Also turn off
`import/extensions` because as far as I can tell it recommends the wrong
thing.

This commit doesn't include changes that prettier would make - adding
another commit for this to keep things easy to review.
travis added a commit that referenced this issue Feb 16, 2023
@travis
chore: update linter, prettier configs (#380)
116a6d8 
Per #296, update linter configs to match https://github.com/web3-storage/w3protocol, minus prettier because it wouldn't stop having bare knuckle boxing matches with eslint that I got sick of mediating.

Use @hugomrdias's `hd-scripts` configs, but turn off a few eslint rules
that either a) I didn't like (no-negated-conditions, no-null) or b) feel
duplicative in TypeScript (all of the jsdoc rules). Also turn off
`import/extensions` because as far as I can tell it recommends the wrong
thing. Without disabling these rules I got errors like this:

<img width="971" alt="Screenshot 2023-02-07 at 4 32 03 PM"
src="https://user-images.githubusercontent.com/1113/217206052-f8c9422a-8a86-45bc-8902-b255515f63e3.png">

I'm definitely open to leaving some of these on if anyone likes them.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@travis travis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update linter, prettier configs storacha/w3ui
2 participants
@travis @olizilla