-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat!: consume access and upload client #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes breaking changes to core and framework components to integrate the access agent (+ucanto 0.9) and the new upload client. resolves #127 BREAKING CHANGE: core and framework components have changed considerably. Please read the updated doucmentation.
This just updates the vanilla #/in example to use the new stuff from #119. I've got the file upload example nearly done as well, but need to wrap things up for the day, so I'll finish it tomorrow. @alanshaw this PR is targeting the branch from #119, so feel free to pull it in there if you want. Otherwise I'll retarget this one after that one merges. Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
I got all these working in a basic way, but had trouble passing the staging service principals and connections through to the providers to test against staging - I think this is the right way to pass them through in Vue: <img width="1264" alt="Screen Shot 2022-11-28 at 5 22 51 PM" src="https://user-images.githubusercontent.com/1113/204416026-4f89cea3-8701-4d56-bc7f-3b4f1d6473e1.png"> but Vue complains like this: <img width="686" alt="Screen Shot 2022-11-28 at 5 24 08 PM" src="https://user-images.githubusercontent.com/1113/204416045-062e3ca3-1863-4121-be34-df3ab577eab3.png"> and the servicePrincipal and connection are undefined inside KeyringProvider - @alanshaw am I just bad at Vue or do we need to do something special to make sure servicePrincipal and connection are defined as "props" in the Providers? Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
This should do the trick to update the various examples, but I haven't tested end to end because I kept getting 500s from the uploads service. Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3e89f35:
|
This was referenced Dec 14, 2022
This was referenced Jan 19, 2023
This was referenced Jan 27, 2023
This was referenced Mar 23, 2023
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](storacha/w3ui@keyring-core-v1.0.2...keyring-core-v2.0.0) (2022-12-14) ### ⚠ BREAKING CHANGES * core and framework components have changed considerably. Please read the updated doucmentation. ### Features * consume access and upload client ([#159](storacha/w3ui#159)) ([dc086fd](storacha/w3ui@dc086fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [3.0.0](storacha/w3ui@uploader-core-v2.0.2...uploader-core-v3.0.0) (2022-12-15) ### ⚠ BREAKING CHANGES * core and framework components have changed considerably. Please read the updated doucmentation. ### Features * consume access and upload client ([#159](storacha/w3ui#159)) ([dc086fd](storacha/w3ui@dc086fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](storacha/w3ui@uploads-list-core-v1.0.3...uploads-list-core-v2.0.0) (2022-12-15) ### ⚠ BREAKING CHANGES * core and framework components have changed considerably. Please read the updated doucmentation. ### Features * consume access and upload client ([#159](storacha/w3ui#159)) ([dc086fd](storacha/w3ui@dc086fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](storacha/w3ui@solid-keyring-v1.0.1...solid-keyring-v2.0.0) (2022-12-15) ### ⚠ BREAKING CHANGES * core and framework components have changed considerably. Please read the updated doucmentation. ### Features * consume access and upload client ([#159](storacha/w3ui#159)) ([dc086fd](storacha/w3ui@dc086fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](storacha/w3ui@react-keyring-v1.0.1...react-keyring-v2.0.0) (2022-12-15) ### ⚠ BREAKING CHANGES * core and framework components have changed considerably. Please read the updated doucmentation. ### Features * consume access and upload client ([#159](storacha/w3ui#159)) ([dc086fd](storacha/w3ui@dc086fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](storacha/w3ui@vue-keyring-v1.0.1...vue-keyring-v2.0.0) (2022-12-15) ### ⚠ BREAKING CHANGES * core and framework components have changed considerably. Please read the updated doucmentation. ### Features * consume access and upload client ([#159](storacha/w3ui#159)) ([dc086fd](storacha/w3ui@dc086fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [3.0.0](storacha/w3ui@solid-uploader-v2.1.2...solid-uploader-v3.0.0) (2022-12-15) ### ⚠ BREAKING CHANGES * core and framework components have changed considerably. Please read the updated doucmentation. ### Features * consume access and upload client ([#159](storacha/w3ui#159)) ([dc086fd](storacha/w3ui@dc086fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [3.0.0](storacha/w3ui@vue-uploader-v2.1.2...vue-uploader-v3.0.0) (2022-12-15) ### ⚠ BREAKING CHANGES * core and framework components have changed considerably. Please read the updated doucmentation. ### Features * consume access and upload client ([#159](storacha/w3ui#159)) ([dc086fd](storacha/w3ui@dc086fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [3.0.0](storacha/w3ui@solid-uploader-v2.1.2...solid-uploader-v3.0.0) (2022-12-15) ### ⚠ BREAKING CHANGES * core and framework components have changed considerably. Please read the updated doucmentation. ### Features * consume access and upload client ([#159](storacha/w3ui#159)) ([dc086fd](storacha/w3ui@dc086fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [3.0.0](storacha/w3ui@react-uploader-v2.1.2...react-uploader-v3.0.0) (2022-12-15) ### ⚠ BREAKING CHANGES * core and framework components have changed considerably. Please read the updated doucmentation. ### Features * consume access and upload client ([#159](storacha/w3ui#159)) ([dc086fd](storacha/w3ui@dc086fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](storacha/w3ui@react-uploads-list-v1.1.2...react-uploads-list-v2.0.0) (2022-12-15) ### ⚠ BREAKING CHANGES * core and framework components have changed considerably. Please read the updated doucmentation. ### Features * consume access and upload client ([#159](storacha/w3ui#159)) ([dc086fd](storacha/w3ui@dc086fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](storacha/w3ui@vue-uploads-list-v1.1.2...vue-uploads-list-v2.0.0) (2022-12-15) ### ⚠ BREAKING CHANGES * core and framework components have changed considerably. Please read the updated doucmentation. ### Features * consume access and upload client ([#159](storacha/w3ui#159)) ([dc086fd](storacha/w3ui@dc086fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](storacha/w3ui@solid-uploads-list-v1.2.2...solid-uploads-list-v2.0.0) (2022-12-15) ### ⚠ BREAKING CHANGES * core and framework components have changed considerably. Please read the updated doucmentation. ### Features * consume access and upload client ([#159](storacha/w3ui#159)) ([dc086fd](storacha/w3ui@dc086fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes breaking changes to core and framework components to integrate the access agent (+ucanto 0.9) and the new upload client.
resolves #127
BREAKING CHANGE: core and framework components have changed considerably. Please read the updated doucmentation.