feat: add cancel create account #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
1ef6632
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bdf33aec.ucan-protocol.pages.dev |
| Branch Preview URL: | https://feat-cancel-create-account.ucan-protocol.pages.dev |
alanshaw
requested changes
Oct 27, 2022
| */ | ||
| async createAccount(email) { | ||
| async createAccount(email, opts) { |
There was a problem hiding this comment.
Need to pass opts to waitForVoucherRedeem.
packages/access/src/agent.js
Outdated
| /** @type {import('./types').EncodedDelegation<[import('./types').VoucherRedeem]>} */ ( | ||
| msg.delegation | ||
| try { | ||
| const msg = await ws.awaitMsg() |
There was a problem hiding this comment.
Suggested change
| const msg = await ws.awaitMsg() | |
| const msg = await ws.awaitMsg(opts) |
packages/access/src/agent.js
Outdated
Comment on lines
225
to
228
| if (error instanceof AbortError) { | ||
| await ws.close() | ||
| throw error | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (error instanceof AbortError) { | |
| await ws.close() | |
| throw error | |
| } | |
| if (error instanceof AbortError) { | |
| await ws.close() | |
| throw error | |
| } | |
| throw new Error('Failed to get voucher/redeem', { cause: error }) |
alanshaw
approved these changes
Oct 29, 2022
alanshaw
pushed a commit
that referenced
this pull request
Nov 1, 2022
🤖 I have created a release *beep* *boop* --- ## [4.0.0](access-v3.1.2...access-v4.0.0) (2022-11-01) ### ⚠ BREAKING CHANGES * Remove 0.8 caps and add account delegation to the service (#123) ### Features * add cancel create account ([#132](#132)) ([feec113](feec113)) * Remove 0.8 caps and add account delegation to the service ([#123](#123)) ([878f8c9](878f8c9)), closes [#117](#117) [#121](#121) ### Bug Fixes * throw error or return value ([#131](#131)) ([cddf7b9](cddf7b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.0](access-v3.1.2...access-v4.0.0) (2022-11-01) ### ⚠ BREAKING CHANGES * Remove 0.8 caps and add account delegation to the service (#123) ### Features * add cancel create account ([#132](#132)) ([0336116](0336116)) * Remove 0.8 caps and add account delegation to the service ([#123](#123)) ([c3c58b9](c3c58b9)), closes [#117](#117) [#121](#121) ### Bug Fixes * throw error or return value ([#131](#131)) ([c9abfb9](c9abfb9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Peeja
referenced
this pull request
in storacha/upload-service
Jan 17, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.