Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add format specifier to blob location claim URL #1445

Merged
merged 2 commits into from
May 13, 2024

Conversation

alanshaw
Copy link
Member

Specifier ensures only the single raw block is served by the gateway. It is not a DAG, it's a single block of content.

@alanshaw alanshaw requested a review from vasco-santos May 13, 2024 09:42
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, but tests need to be updated I believe

Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good,

@alanshaw alanshaw merged commit 9982d12 into main May 13, 2024
14 checks passed
@alanshaw alanshaw deleted the fix/add-format-specifier branch May 13, 2024 12:29
travis pushed a commit that referenced this pull request May 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[14.0.0](upload-api-v13.0.2...upload-api-v14.0.0)
(2024-05-14)


### ⚠ BREAKING CHANGES

* deprecate issuer
([#1344](#1344))

### Features

* add "plan/create-admin-session" capability
([#1411](#1411))
([50eeeb5](50eeeb5))
* add blob protocol to upload-client
([#1425](#1425))
([49aef56](49aef56))
* deprecate issuer
([#1344](#1344))
([afbbde3](afbbde3))
* move blob index logic from upload-api to blob-index lib
([#1434](#1434))
([797f628](797f628))
* remove issuer row
([#1345](#1345))
([cf5b0db](cf5b0db))


### Fixes

* `encodeURIComponent` on bucket origin
([#1448](#1448))
([5618644](5618644))
* add format specifier to blob location claim URL
([#1445](#1445))
([9982d12](9982d12))
* test against actual api
([#1438](#1438))
([f8132ca](f8132ca))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants