Skip to content
This repository was archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

fix for issue #162 - adding pods/log permission to the cluster-operator #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

esara
Copy link

@esara esara commented Sep 7, 2019

cluster-operator can check the logs after the creation of the job

@darkowlzz
Copy link
Contributor

Hi, thanks for submitting a fix for this issue. job and storageosupgrade CRDs are not maintained for now. When they were added in the operator, operator used to have cluster admin role. Later specific permissions were added and cluster admin requirement was removed. Since job and storageosupgrade CRDs weren't maintained or tested, the permissions required for them have not been added in the operator. We will be adding automated tests and maintain those two CRDs in the coming months.
The fix looks good and it'll work when the operator is deployed using the manifest files. But we also support other means of installing the operator, like using OLM (Operator Lifecycle Manager). For that, can you please add the same change in storageos-operators.configmap.yaml and then run make metadata-update to populate the same change in all the various places it's required?
Also, would be great if you could squash all the commits into a single commit.

Thanks for reporting and working on it.

@esara esara reopened this Mar 28, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants